We give a systematic study of the HER catalytic activity of transition metal doped NiS2 by first principles calculations and experiments.